Adds a script to unmount any mount points in your boards image dir and free loopback devices

Adds a script to unmount any mount points in your boards image dir and free loopback devices

[sosa, 2010-04-29 17:42:39]

Added you since you prob know as much as me how pesky things can get when
working with build_image.

[Bill Richardson, 2010-04-29 18:21:02]

Seems dangerous to me.

http://codereview.chromium.org/1759015/diff/2001/3001
File src/scripts/clean_loopback_devices.sh (right):

http://codereview.chromium.org/1759015/diff/2001/3001#newcode33
src/scripts/clean_loopback_devices.sh:33: sudo losetup -d /dev/loop* 2>
/dev/null
!!! This will destroy any loop devices on the entire computer, not just ones in
use from within the chroot.
AFAIK, there's no way to tell which devices are in use by this particular
chroot, except to keep track of them as they're created.

[sosa, 2010-04-29 18:30:36]

http://codereview.chromium.org/1759015/diff/2001/3001
File src/scripts/clean_loopback_devices.sh (right):

http://codereview.chromium.org/1759015/diff/2001/3001#newcode33
src/scripts/clean_loopback_devices.sh:33: sudo losetup -d /dev/loop* 2>
/dev/null
I thought this too at first.  But in fact, you can't unmount or delete loopback
devices from within a chroot of the outer device.  losetup -d will report the
device is busy and it can't be freed.  I just tested this by mounting a bunch of
loopback devices (in another chroot and not in a chroot at all) and this script
only freed the loopback devices and mount points within this chroot.

On 2010/04/29 18:21:02, Bill Richardson wrote:
> !!! This will destroy any loop devices on the entire computer, not just ones
in
> use from within the chroot.
> AFAIK, there's no way to tell which devices are in use by this particular
> chroot, except to keep track of them as they're created.
>

[Bill Richardson, 2010-04-29 19:35:18]

Huh. Okay, if you're sure, I'll give it my LGTM. You might add a comment with
that claim to the script, though.

[sosa, 2010-04-29 20:31:14]

sounds good.  thanks for the reviews!

On Thu, Apr 29, 2010 at 12:35 PM,  <wfrichar@chromium.org> wrote:
> Huh. Okay, if you're sure, I'll give it my LGTM. You might add a comment
> with
> that claim to the script, though.
>
>
>
>
> http://codereview.chromium.org/1759015/show
>