Issue 1759011: Prepare push to trunk. Now working on 2.2.7.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1759011: Prepare push to trunk. Now working on 2.2.7. (Closed)

Created:
10 years, 7 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Prepare push to trunk. Now working on 2.2.7. Committed: http://code.google.com/p/v8/source/detail?r=4535

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix premature change of CANDIDATE_VERSION #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -3 lines)			Patch
	M	ChangeLog	View		2 chunks	+13 lines, -2 lines	0 comments	Download
	M	src/version.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

10 years, 7 months ago (2010-04-28 11:57:18 UTC) #2

LGTM except for the candidate revision flag change.

http://codereview.chromium.org/1759011/diff/1/3
File src/version.cc (right):

http://codereview.chromium.org/1759011/diff/1/3#newcode39
src/version.cc:39: #define CANDIDATE_VERSION false
Leave true in here, change to false when committing to trunk.

Expand Messages | Collapse Messages