Issue 1759007: Refactor parts of the NTP to split things into more managable chunks....

Issue 1759007: Refactor parts of the NTP to split things into more managable chunks.... (Closed)

Created:
10 years, 8 months ago by arv (Not doing code reviews)

Modified:
9 years, 4 months ago

Reviewers:
feldstein

CC:
chromium-reviews, Paul Godavari, arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Refactor parts of the NTP to split things into more managable chunks. BUG=None TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45631

Patch Set 2 : Add license headers #

Patch Set 3 : Revert class/tag name changes in html file #

Total comments: 1

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+262 lines, -3392 lines)			Patch
M	chrome/browser/browser_resources.grd	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/downloads.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/filebrowse.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/history.html	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/resources/i18n_template.js	View		1 chunk	+0 lines, -104 lines	0 comments	Download
D	chrome/browser/resources/local_strings.js	View		1 chunk	+0 lines, -47 lines	0 comments	Download
M	chrome/browser/resources/mediaplayer.html	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/resources/new_new_tab.html	View	1 2	1 chunk	+4 lines, -2 lines	1 comment	Download
M	chrome/browser/resources/new_new_tab.js	View	1	9 chunks	+3 lines, -565 lines	0 comments	Download
A +	chrome/browser/resources/ntp/most_visited.js	View	1	7 chunks	+3 lines, -1126 lines	0 comments	Download
M	chrome/browser/resources/playlist.html	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A	chrome/browser/resources/shared/js/i18n_template.js	View	1	1 chunk	+108 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/shared/js/local_strings.js	View	1	1 chunk	+47 lines, -0 lines	0 comments	Download
A +	chrome/browser/resources/shared/js/parse_html_subset.js	View		2 chunks	+0 lines, -1536 lines	0 comments	Download
A	chrome/browser/resources/shared/js/parse_html_subset_test.html	View		1 chunk	+85 lines, -0 lines	0 comments	Download
M	chrome/common/common_resources.grd	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

I had some trouble with glc so I ended up not doing svn move fro ...

10 years, 8 months ago (2010-04-23 23:28:04 UTC) #2

feldstein

LGTM, one question http://codereview.chromium.org/1759007/diff/6001/7001 File chrome/browser/resources/new_new_tab.html (right): http://codereview.chromium.org/1759007/diff/6001/7001#newcode189 chrome/browser/resources/new_new_tab.html:189: <div id="option-menu" class="window-menu"> You mentioned in ...

10 years, 8 months ago (2010-04-24 00:16:54 UTC) #3

arv (Not doing code reviews)

10 years, 8 months ago (2010-04-24 00:18:12 UTC) #4

On Fri, Apr 23, 2010 at 17:16,  <feldstein@chromium.org> wrote:
> LGTM, one question
>
>
> http://codereview.chromium.org/1759007/diff/6001/7001
> File chrome/browser/resources/new_new_tab.html (right):
>
> http://codereview.chromium.org/1759007/diff/6001/7001#newcode189
> chrome/browser/resources/new_new_tab.html:189: <div id="option-menu"
> class="window-menu">
> You mentioned in the mail that there were no code changes... did you
> mean to submit this?

No. I though I uploaded another snapshot.

>
> http://codereview.chromium.org/1759007/show
>

Expand Messages | Collapse Messages