Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Unified Diff: pylibs/buildbot/process/buildstep.py

Issue 1759006: Reduce verbosity in twistd.log on the try server. (Closed)
Patch Set: Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylibs/buildbot/process/buildstep.py
diff --git a/pylibs/buildbot/process/buildstep.py b/pylibs/buildbot/process/buildstep.py
index 4eb1076a382c71ca1dbbfd3d724444ec3d8993dd..8254d2e2edca38b89091e2b89856714d03c7792c 100644
--- a/pylibs/buildbot/process/buildstep.py
+++ b/pylibs/buildbot/process/buildstep.py
@@ -1008,7 +1008,17 @@ class LoggingBuildStep(BuildStep):
all output being put into our self.stdio_log LogFile
"""
log.msg("ShellCommand.startCommand(cmd=%s)" % (cmd,))
- log.msg(" cmd.args = %r" % (cmd.args))
+ args = cmd.args
+ if "patch" in cmd.args:
+ # Don't print the patch in the logs, it's often too large and not
+ # useful.
+ args = cmd.args.copy()
+ # This is usually a tuple so convert it to a list to be able to modify
+ # it.
+ patch = list(args['patch'][:])
+ patch[1] = "(%s bytes)" % len(patch[1])
+ args['patch'] = patch
+ log.msg(" cmd.args = %r" % (args))
self.cmd = cmd # so we can interrupt it
self.step_status.setText(self.describe(False))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698