Issue 1756017: Color by default only if TTY stdout. Recurse into results directories.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1756017: Color by default only if TTY stdout. Recurse into results directories. (Closed)

Created:
10 years, 8 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
kmixter1

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git/chromeos

Visibility:
Public.

Description

Color by default only if TTY stdout. Recurse into results directories.

Patch Set 2 : Make the constant private. #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -10 lines)			Patch
	M	src/scripts/generate_test_report	View	1	6 chunks	+19 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

petkov

... for BVTs, the recursion makes the report print separate lines for BootPerfServer and BootPerf ...

10 years, 8 months ago (2010-04-28 06:06:52 UTC) #1

kmixter1

LGTM http://codereview.chromium.org/1756017/diff/1/2 File src/scripts/generate_test_report (right): http://codereview.chromium.org/1756017/diff/1/2#newcode21 src/scripts/generate_test_report:21: STDOUT_IS_TTY = hasattr(sys.stdout, 'isatty') and sys.stdout.isatty() _STDOUT_IS_TTY?

10 years, 7 months ago (2010-04-29 16:20:59 UTC) #2