Issue 1756007: Fix error in static type information computation for bitwise shift.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1756007: Fix error in static type information computation for bitwise shift. (Closed)

Created:
10 years, 8 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix error in static type information computation for bitwise shift. Committed: http://code.google.com/p/v8/source/detail?r=4471

Patch Set 1 #

Total comments: 2

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -8 lines)			Patch
M	src/ia32/codegen-ia32.cc	View	1 chunk	+13 lines, -6 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/mjsunit/smi-ops.js	View	1 chunk	+9 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/1756007/diff/1/2 File test/mjsunit/smi-ops.js (right): http://codereview.chromium.org/1756007/diff/1/2#newcode680 test/mjsunit/smi-ops.js:680: assertEquals(4589934592, LogicalShiftRightByMultipleOf32(-2000000000)); Why the same line twice?

10 years, 8 months ago (2010-04-22 08:59:04 UTC) #2

William Hesse

10 years, 8 months ago (2010-04-22 09:01:29 UTC) #3

http://codereview.chromium.org/1756007/diff/1/2
File test/mjsunit/smi-ops.js (right):

http://codereview.chromium.org/1756007/diff/1/2#newcode680
test/mjsunit/smi-ops.js:680: assertEquals(4589934592,
LogicalShiftRightByMultipleOf32(-2000000000));
On 2010/04/22 08:59:04, Lasse Reichstein wrote:
> Why the same line twice?

Because the function returns different answers each time, due to binary
operation inline caches.

Expand Messages | Collapse Messages