Issue 1756003: Fix issue 683: change the order of CPU profiler setup actions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1756003: Fix issue 683: change the order of CPU profiler setup actions. (Closed)

Created:
10 years, 8 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Fix issue 683: change the order of CPU profiler setup actions. BUG=683 Committed: http://code.google.com/p/v8/source/detail?r=4464

Patch Set 1 #

Total comments: 1

Patch Set 2 : URL #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	src/cpu-profiler.cc	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

10 years, 8 months ago (2010-04-21 14:04:31 UTC) #2

LGTM

http://codereview.chromium.org/1756003/diff/1/2
File src/cpu-profiler.cc (right):

http://codereview.chromium.org/1756003/diff/1/2#newcode424
src/cpu-profiler.cc:424: // It is important to have it started prior to logging,
see issue 683.
Could you put in the URL for the issue to make it completely explicit?

Expand Messages | Collapse Messages