Rework a bit the NetworkList implementation.

Rework a bit the NetworkList implementation.

BUG=None
TEST=None

Patch from Thiago Farina <thiago.farina@gmail.com>;

[tfarina (gmail-do not use), 2010-04-30 16:43:46]

Hi Nikita, could you review this to me?

[Nikita (slow), 2010-05-04 17:46:30]

According to
http://dev.chromium.org/developers/coding-style

"Some code uses CamelCase for everything; avoid writing patches just to convert
these functions to unix_hacker style, but try to use it in new code you write."

http://codereview.chromium.org/1755021/diff/2001/3003
File chrome/browser/chromeos/network_list.h (right):

http://codereview.chromium.org/1755021/diff/2001/3003#newcode69
chrome/browser/chromeos/network_list.h:69: int size() const { return
static_cast<int>(networks_.size()); }
I believe size() should still return size_t and when it's compared with int it's
better to leave static_cast<int>(...).

[tfarina (gmail-do not use), 2010-05-04 18:18:46]

On 2010/05/04 17:46:30, Nikita Kostylev wrote:
> According to
> http://dev.chromium.org/developers/coding-style
> 
> "Some code uses CamelCase for everything; avoid writing patches just to
convert
> these functions to unix_hacker style, but try to use it in new code you
write."
> 
I didn't have this in mind. I was trying to make it more in conform with the
chromium code style. Also because there is a TODO to refactor this class. So
this was my first attempt.

http://codereview.chromium.org/1755021/diff/2001/3003
File chrome/browser/chromeos/network_list.h (right):

http://codereview.chromium.org/1755021/diff/2001/3003#newcode69
chrome/browser/chromeos/network_list.h:69: int size() const { return
static_cast<int>(networks_.size()); }
On 2010/05/04 17:46:30, Nikita Kostylev wrote:
> I believe size() should still return size_t and when it's compared with int
it's
> better to leave static_cast<int>(...).

Is better? Could you elaborate here?

(Why you would want to use static_cast everytime/everywhere?)

[Nikita (slow), 2010-05-05 13:41:40]

Idea was to refactor/merger with network list model used in status area/options
but it's a big effort.

If you want to go down that path please make more essential changes even in this
CL to prepare these models for merge.

My idea was to add additional functionality to NetworkList so that it could be
used in NetworkMenuButton. Current situation: NetworkMenuButton has combined
view/model.

http://codereview.chromium.org/1755021/diff/2001/3003
File chrome/browser/chromeos/network_list.h (right):

http://codereview.chromium.org/1755021/diff/2001/3003#newcode69
chrome/browser/chromeos/network_list.h:69: int size() const { return
static_cast<int>(networks_.size()); }
On 2010/05/04 18:18:46, tfarina wrote:
> On 2010/05/04 17:46:30, Nikita Kostylev wrote:
> > I believe size() should still return size_t and when it's compared with int
> it's
> > better to leave static_cast<int>(...).
> 
> Is better? Could you elaborate here?
> 
> (Why you would want to use static_cast everytime/everywhere?)
> 

Argument was to use size_t for size() to keep consistency with the rest of
Chrome code base.
That leaves you with static_cast when comparing with int.

[Nikita (slow), 2010-05-06 13:35:35]

Here's related refactoring CL that Charlie uploaded
http://codereview.chromium.org/2010001

[tfarina (gmail-do not use), 2010-05-06 16:09:09]

On 2010/05/06 13:35:35, Nikita Kostylev wrote:
> Here's related refactoring CL that Charlie uploaded
> http://codereview.chromium.org/2010001

Cool, I saw that Charlie is going to take the ownership of this refactoring.

So, I'm going to close this issue.

[Nikita (slow), 2010-05-13 10:52:13]

Thiago, could you please close this issue?
Thanks.

[tfarina (gmail-do not use), 2010-05-13 13:20:14]

On 2010/05/13 10:52:13, Nikita Kostylev wrote:
> Thiago, could you please close this issue?
> Thanks.
Forgotten, closeed