Issue 1755017: A couple of SPDY server push bug fixes....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1755017: A couple of SPDY server push bug fixes.... (Closed)

Created:
10 years, 7 months ago by Mike Belshe

Modified:
9 years, 5 months ago

Reviewers:
Matthew Lloyd

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

A couple of SPDY server push bug fixes. GFE and the SPDY spec both require lower-case headers, so I've updated the Chrome SPDY stack and the unit tests to use lower-case x-associated-content. Also fixes a bug in SpdyStream::DoReadBody that breaks push streams in certain situations (they never get their body data). Landing for Matthew Lloyd (mlloyd@google.com) BUG=none TEST=SpdyNetworkTransactionTest.ServerPush Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46000

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -4 lines)			Patch
M	net/spdy/spdy_network_transaction_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/spdy/spdy_session.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/spdy/spdy_stream.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Matthew Lloyd

10 years, 7 months ago (2010-04-29 17:05:49 UTC) #2

LGTM.

Once this is landed, I'd like to apply for provisional commit access and start
the 6-week clock. Who do I need to speak to?

Thanks - Matthew

Expand Messages | Collapse Messages