Make modify-image-for-factory scripts more readable.

Make modify-image-for-factory scripts more readable.

[kmixter1, 2010-04-27 17:21:32]

Since this is modifying Nick's layout, I'll defer the LGTM to him.  I do think
this is a more readable, but the mod_image_for_test script and mod_for_*
directories are planned to be scrapped and moved into ebuilds.  Still, I don't
think improving readability ever hurts.

http://codereview.chromium.org/1755012/diff/1/5
File src/scripts/mod_for_factory_scripts/500copyQualDb (right):

http://codereview.chromium.org/1755012/diff/1/5#newcode7
src/scripts/mod_for_factory_scripts/500copyQualDb:7: # Try to use the sytem
component file in the most recent autotest result
system

http://codereview.chromium.org/1755012/diff/1/5#newcode8
src/scripts/mod_for_factory_scripts/500copyQualDb:8: QUALDB_ROOT=$(ls -dt
${QUALDB_ROOT} 2>&-| head -1)
might be good to document the expected file structure at the top of this file. 
I'm a little lost looking through all the different uses of QUALDB_ROOT.

http://codereview.chromium.org/1755012/diff/1/8
File src/scripts/mod_image_for_test.sh (right):

http://codereview.chromium.org/1755012/diff/1/8#newcode118
src/scripts/mod_image_for_test.sh:118: # Run test setup script inside chroot
jail to modify the image
This comment is not accurate - we're not running in a chroot jail.

[Nick Sanders, 2010-04-27 21:41:25]

lgtm, I don't think we should move to ebuilds until we've automated a way to
build and image reasonably quickly. So cleaning up is definitely worthwhile.

[Tom Wai-Hong Tam, 2010-04-28 03:22:24]

Fixed according to your suggestions.

http://codereview.chromium.org/1755012/diff/1/5
File src/scripts/mod_for_factory_scripts/500copyQualDb (right):

http://codereview.chromium.org/1755012/diff/1/5#newcode8
src/scripts/mod_for_factory_scripts/500copyQualDb:8: QUALDB_ROOT=$(ls -dt
${QUALDB_ROOT} 2>&-| head -1)
Documented the file structure above the script.

http://codereview.chromium.org/1755012/diff/1/8
File src/scripts/mod_image_for_test.sh (right):

http://codereview.chromium.org/1755012/diff/1/8#newcode118
src/scripts/mod_image_for_test.sh:118: # Run test setup script inside chroot
jail to modify the image
On 2010/04/27 17:21:32, kmixter1 wrote:
> This comment is not accurate - we're not running in a chroot jail.

Done.

[kmixter1, 2010-04-28 17:09:15]

Thanks for those updates.  I didn't realize the system components db was still
pulled from a prior hwqual run.  We'll want to submit those component files to
an internal repo, keyed by their corresponding hwqual ids, and provide them to
partners upon hwqual certification.  So eventually the qualdb will probably be
just a complete path to the file.