Don't delete the user profile directory for tests that ran with --user-data-d...

Don't delete the user profile directory for tests that ran with --user-data-dir.

Committing for rsimha@chromium.org. Original review: http://codereview.chromium.org/1739007/show

Added a boolean field to class ChromeTestSuite, called "created_user_data_dir_". It defaults to false, and is set to true if no value is passed for --user_data_dir via command line. If the flag is false, the directory specified by the user is not deleted after test execution, and if it is true, the directory is deleted, as it always has been.

Note: user_data_dir is emptied before test execution -- this behavior remains unaltered.

BUG=42374
TEST=User profile directory still exists after running a test with --user-data-dir.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45673

[Evan Stade, 2010-04-27 00:00:14]

http://codereview.chromium.org/1755009/diff/1/2
File chrome/test/unit/chrome_test_suite.h (right):

http://codereview.chromium.org/1755009/diff/1/2#newcode164
chrome/test/unit/chrome_test_suite.h:164:
CommandLine::ForCurrentProcess()->GetSwitchValuePath(
nit: I would make a member boolean that stores whether we created a new dir or
used a command line dir, so that we don't duplicate code and there's no chance
that it will ever do the wrong thing (in weird cases such as a failure to create
the temp directory, or if the test edits the command line)

[Lei Zhang, 2010-04-27 00:05:38]

On 2010/04/27 00:00:14, Evan Stade wrote:
> http://codereview.chromium.org/1755009/diff/1/2
> File chrome/test/unit/chrome_test_suite.h (right):
> 
> http://codereview.chromium.org/1755009/diff/1/2#newcode164
> chrome/test/unit/chrome_test_suite.h:164:
> CommandLine::ForCurrentProcess()->GetSwitchValuePath(
> nit: I would make a member boolean that stores whether we created a new dir or
> used a command line dir, so that we don't duplicate code and there's no chance
> that it will ever do the wrong thing (in weird cases such as a failure to
create
> the temp directory, or if the test edits the command line)

Then I should just commit http://codereview.chromium.org/1739007/show ?