Chromium Code Reviews

Unified Diff: src/arm/disasm-arm.cc

Issue 1755001: Update comment to provide the correct usage of the Disassembler class.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/arm/disasm-arm.cc
===================================================================
--- src/arm/disasm-arm.cc (revision 4452)
+++ src/arm/disasm-arm.cc (working copy)
@@ -34,10 +34,9 @@
// NameConverter converter;
// Disassembler d(converter);
// for (byte* pc = begin; pc < end;) {
-// char buffer[128];
-// buffer[0] = '\0';
+// v8::internal::EmbeddedVector<char, 256> buffer;
// byte* prev_pc = pc;
-// pc += d.InstructionDecode(buffer, sizeof buffer, pc);
+// pc += d.InstructionDecode(buffer, pc);
// printf("%p %08x %s\n",
// prev_pc, *reinterpret_cast<int32_t*>(prev_pc), buffer);
// }
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine