Issue 1752003: Roll Skia forward to r524.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1752003: Roll Skia forward to r524. (Closed)

Created:
10 years, 8 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
Stephen White, agl

CC:
chromium-reviews, darin-cc_chromium.org, dpranke+watch_chromium.org, pam+watch_chromium.org

Visibility:
Public.

Description

Roll Skia forward to r524. My target is farther than that, but I'm doing this incrementally. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45223

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	webkit/tools/layout_tests/test_expectations.txt	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

agl

LGTM although a voice in my head says that we might have moved test_expectations upstream.

10 years, 8 months ago (2010-04-21 19:59:04 UTC) #2

Evan Martin

On 2010/04/21 19:59:04, agl wrote: > LGTM although a voice in my head says that ...

10 years, 8 months ago (2010-04-21 20:00:05 UTC) #3

Stephen White

10 years, 8 months ago (2010-04-21 20:02:09 UTC) #4

I think this is ok -- we have a local copy that we can append tests for
temporary situations, like this one.

On Wed, Apr 21, 2010 at 3:59 PM, <agl@chromium.org> wrote:

> LGTM although a voice in my head says that we might have moved
> test_expectations
> upstream.
>
>
> http://codereview.chromium.org/1752003/show
>

-- 
All truth passes through three stages. First, it is ridiculed. Second, it is
violently opposed. Third, it is accepted as being self-evident. --
Schopenhauer

Expand Messages | Collapse Messages