Change the LoadIC calling convention so that the receiver...

Change the LoadIC calling convention so that the receiver
is both on top of the stack and also in r0.  This makes
sense because the receiver is usually in r0 anyway.  We may
remove it from the stack later.  Also removes some spilled
scopes from the code generator allowing it to keep expression
temporaries in registers more.

Committed: http://code.google.com/p/v8/source/detail?r=4518

[Søren Thygesen Gjesse, 2010-04-26 15:09:39]

http://codereview.chromium.org/1751019/diff/1/8
File src/arm/ic-arm.cc (right):

http://codereview.chromium.org/1751019/diff/1/8#newcode51
src/arm/ic-arm.cc:51: Register t1) {
Wouldn't it be better to pass all the used registers as arguments?

http://codereview.chromium.org/1751019/diff/1/8#newcode56
src/arm/ic-arm.cc:56: // t1 - initially the receiver
t1 is no longer "used for the index into the property dictionary"

http://codereview.chromium.org/1751019/diff/1/6
File src/arm/virtual-frame-arm.h (right):

http://codereview.chromium.org/1751019/diff/1/6#newcode345
src/arm/virtual-frame-arm.h:345: void SpillAllButCopyTOSToR0();
This function is not really used by this change.

[Søren Thygesen Gjesse, 2010-04-26 15:09:44]

LGTM

[Erik Corry, 2010-04-26 21:45:35]

http://codereview.chromium.org/1751019/diff/1/6
File src/arm/virtual-frame-arm.h (right):

http://codereview.chromium.org/1751019/diff/1/6#newcode345
src/arm/virtual-frame-arm.h:345: void SpillAllButCopyTOSToR0();
On 2010/04/26 15:09:39, Søren Gjesse wrote:
> This function is not really used by this change.

For some reason the upload of the change didn't work.  I've now added the file
where it is used (codegen-arm.cc) and done another upload.  Sorry about that.

[Søren Thygesen Gjesse, 2010-04-27 06:55:40]

LGTM

http://codereview.chromium.org/1751019/diff/10001/11008
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/1751019/diff/10001/11008#newcode2982
src/arm/codegen-arm.cc:2982: ContextSlotOperandCheckExtensions(potential_slot,
Would it be possible to change this like LoadFromGlobalSlotCheckExtensions, that
is move the spilling into it and get rid of the temp register arguments? And
maybe move it to its own statement to avoid having an argument to a macro
assembler call which generates code.

http://codereview.chromium.org/1751019/diff/10001/11008#newcode5324
src/arm/codegen-arm.cc:5324: __ IncrementCounter(&Counters::named_load_inline,
1, r3, r4);
Wouldn't it be better to use frame_->scratch0() and frame_->scratch1() here?