Compute static type information for remaining expression types on x64 platfor...

Compute static type information for remaining expression types on x64 platform.

Committed: http://code.google.com/p/v8/source/detail?r=4481

[Lasse Reichstein, 2010-04-23 06:59:56]

LGTM

http://codereview.chromium.org/1751008/diff/1/3
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/1751008/diff/1/3#newcode5738
src/x64/codegen-x64.cc:5738: ASSERT(kSmiValueSize == 32);
Use STATIC_ASSERT for asserts that can be checked at compile time.

http://codereview.chromium.org/1751008/diff/1/3#newcode5764
src/x64/codegen-x64.cc:5764: } else if (operands_type.IsString()) {
You can do better here: The result is a string if either of the operands is a
string. I.e.
if (left.type_info().IsString() || right.type_info().IsString()) { ...

[William Hesse, 2010-04-23 08:04:26]

http://codereview.chromium.org/1751008/diff/1/3
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/1751008/diff/1/3#newcode5738
src/x64/codegen-x64.cc:5738: ASSERT(kSmiValueSize == 32);
On 2010/04/23 06:59:56, Lasse Reichstein wrote:
> Use STATIC_ASSERT for asserts that can be checked at compile time.

Done.

http://codereview.chromium.org/1751008/diff/1/3#newcode5764
src/x64/codegen-x64.cc:5764: } else if (operands_type.IsString()) {
On 2010/04/23 06:59:56, Lasse Reichstein wrote:
> You can do better here: The result is a string if either of the operands is a
> string. I.e.
> if (left.type_info().IsString() || right.type_info().IsString()) { ...

Done.