Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 175027: Update BackingStore to handle the case where our Cocoa view has... (Closed)

Created:
11 years, 3 months ago by Amanda Walker
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Update BackingStore to handle the case where our Cocoa view has not been inserted into a window yet. BUG=20009 TEST=tabs opened in the background should not be blank when you switch to them. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24941

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -39 lines) Patch
M chrome/browser/renderer_host/backing_store.h View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/backing_store_mac.mm View 1 2 3 chunks +95 lines, -33 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_mac.mm View 2 chunks +18 lines, -6 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
Amanda Walker
11 years, 3 months ago (2009-08-31 20:20:37 UTC) #1
rohitrao (ping after 24h)
LGTM The latest patch was added because I asked what would happen if the RWHVCocoa ...
11 years, 3 months ago (2009-08-31 21:18:13 UTC) #2
Amanda Walker
11 years, 3 months ago (2009-08-31 21:22:30 UTC) #3
http://codereview.chromium.org/175027/diff/5001/5004
File chrome/browser/renderer_host/render_widget_host_view_mac.mm (right):

http://codereview.chromium.org/175027/diff/5001/5004#newcode577
Line 577: CGBitmapContextCreateImage(backing_store->cg_bitmap()));
On 2009/08/31 21:18:13, rohitrao wrote:
> What will happen if cg_bitmap() returns NULL?  Do we want to add a DCHECK to
> make sure either the layer or the bitmap exists?

Since one or the other always gets created in the BackingStore constructor, I
don't see too much need for a check here.  Since CGBitmapContextCreate should
only fail if the process is completely out of RAM, it seems a bit superfluous to
add a check for that case in the constructor, but that would be the place to do
it.

Powered by Google App Engine
This is Rietveld 408576698