Issue 1750015: glGetProgramiv was returning incorrect values for GL_ACTIVE_UNIFORM_MAX_LENGT...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1750015: glGetProgramiv was returning incorrect values for GL_ACTIVE_UNIFORM_MAX_LENGT... (Closed)

Created:
10 years, 8 months ago by alokp

Modified:
9 years, 6 months ago

Reviewers:
greggman, apatrick

CC:
chromium-reviews, apatrick_chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

glGetProgramiv was returning incorrect values for GL_ACTIVE_UNIFORM_MAX_LENGTH and GL_ACTIVE_ATTRIBUTE_MAX_LENGTH. It was not adjusting for NULL terminator. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45732

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	gpu/command_buffer/service/program_manager.cc	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
	M	gpu/command_buffer/service/program_manager_unittest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

greggman

I think it would be less confusing to move the +1 down to getProgramiv Otherwise ...

10 years, 8 months ago (2010-04-26 22:42:02 UTC) #2

lgtm