Issue 1750001: Don't process the same address for throttling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1750001: Don't process the same address for throttling. (Closed)

Created:
10 years, 8 months ago by ukai

Modified:
9 years, 7 months ago

Reviewers:
tyoshino (SeeGerritForStatus), Yuta Kitamura

CC:
chromium-reviews, jam, Paweł Hajdan Jr., cbentzel+watch_chromium.org, darin-cc_chromium.org

Visibility:
Public.

Description

Don't process the same address for websocket throttling. Host resolver might return address list that contains the same address twice or more. In this case, we should not process the address for websocket throttling multiple times. If we don't have duplicate check of address, it would put the job throttle by the job itself (deadlock). I think this is cause of failure in Linux perf (webkit.org) bot and websocket fail to connect localhost on ubuntu (crbug.com/36652) BUG=36652, 41319, 40995 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45156

Patch Set 1 #

Patch Set 2 : add test #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -0 lines)			Patch
	M	net/websockets/websocket_throttle.cc	View		4 chunks	+16 lines, -0 lines	0 comments	Download
	M	net/websockets/websocket_throttle_unittest.cc	View		1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tyoshino (SeeGerritForStatus)

10 years, 8 months ago (2010-04-21 06:49:30 UTC) #2

LGTM


In description:
might returns -> might return

Expand Messages | Collapse Messages