Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9116)

Unified Diff: chrome_frame/chrome_frame_reporting.cc

Issue 1748016: Avoid reporting crashes for exceptions that hit our SEH from calls to the ori... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome_frame/crash_reporting/crash_report.cc » ('j') | chrome_frame/exception_barrier.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/chrome_frame_reporting.cc
===================================================================
--- chrome_frame/chrome_frame_reporting.cc (revision 45764)
+++ chrome_frame/chrome_frame_reporting.cc (working copy)
@@ -46,11 +46,6 @@
return &custom_info;
}
-
-void CALLBACK BreakpadHandler(EXCEPTION_POINTERS *ptrs) {
- WriteMinidumpForException(ptrs);
-}
-
extern "C" IMAGE_DOS_HEADER __ImageBase;
bool InitializeCrashReporting() {
@@ -61,9 +56,9 @@
if (!always_take_dump && !GoogleUpdateSettings::GetCollectStatsConsent())
return true;
- // Set the handler for ExceptionBarrier for this module:
- DCHECK(ExceptionBarrier::handler() == NULL);
- ExceptionBarrier::set_handler(BreakpadHandler);
+ // If we got here, we want to report crashes, so make sure all
+ // ExceptionBarrierBase instances do so.
+ ExceptionBarrierConfig::set_enabled(true);
// Get the alternate dump directory. We use the temp path.
FilePath temp_directory;
@@ -97,5 +92,6 @@
}
bool ShutdownCrashReporting() {
+ ExceptionBarrierConfig::set_enabled(false);
return ShutdownVectoredCrashReporting();
}
« no previous file with comments | « no previous file | chrome_frame/crash_reporting/crash_report.cc » ('j') | chrome_frame/exception_barrier.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698