chrome_frame/exception_barrier_lowlevel.asm - Issue 1748016: Avoid reporting crashes for exceptions that hit our SEH from calls to the ori...

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome_frame/exception_barrier_lowlevel.asm

Issue 1748016: Avoid reporting crashes for exceptions that hit our SEH from calls to the ori... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 10 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 ; Copyright (c) 2010 The Chromium Authors. All rights reserved.	1 ; Copyright (c) 2010 The Chromium Authors. All rights reserved.

2 ; Use of this source code is governed by a BSD-style license that can be	2 ; Use of this source code is governed by a BSD-style license that can be

3 ; found in the LICENSE file.	3 ; found in the LICENSE file.

4 ;	4 ;

5 ; Tag the exception handler as an SEH handler in case the executable	5 ; Tag the exception handler as an SEH handler in case the executable

6 ; is linked with /SAFESEH (which is the default).	6 ; is linked with /SAFESEH (which is the default).

7 ;	7 ;

8 ; MASM 8.0 inserts an additional leading underscore in front of names	8 ; MASM 8.0 inserts an additional leading underscore in front of names

9 ; and this is an attempted fix until we understand why.	9 ; and this is an attempted fix until we understand why.

10 IF @version LT 800	10 IF @version LT 800

11 _ExceptionBarrierHandler PROTO	11 _ExceptionBarrierHandler PROTO

12 .SAFESEH _ExceptionBarrierHandler	12 .SAFESEH _ExceptionBarrierHandler

	13 _ExceptionBarrierReportOnlyModuleHandler PROTO

	14 .SAFESEH _ExceptionBarrierReportOnlyModuleHandler

	15 _ExceptionBarrierCallCustomHandler PROTO

	16 .SAFESEH _ExceptionBarrierCallCustomHandler

13 ELSE	17 ELSE

14 ExceptionBarrierHandler PROTO	18 ExceptionBarrierHandler PROTO

15 .SAFESEH ExceptionBarrierHandler	19 .SAFESEH ExceptionBarrierHandler

	20 ExceptionBarrierReportOnlyModuleHandler PROTO

	21 .SAFESEH ExceptionBarrierReportOnlyModuleHandler

	22 ExceptionBarrierCallCustomHandler PROTO

	23 .SAFESEH ExceptionBarrierCallCustomHandler

16 ENDIF	24 ENDIF

17	25

18 .586	26 .586

19 .MODEL FLAT, STDCALL	27 .MODEL FLAT, STDCALL

20 ASSUME FS:NOTHING	28 ASSUME FS:NOTHING

21 .CODE	29 .CODE

22	30

23 ; extern "C" void WINAPI RegisterExceptionRecord(	31 ; extern "C" void WINAPI RegisterExceptionRecord(

24 ; EXCEPTION_REGISTRATION *registration,	32 ; EXCEPTION_REGISTRATION *registration,

25 ; ExceptionHandlerFunc func);	33 ; ExceptionHandlerFunc func);

(...skipping 17 matching lines...) Expand all Loading...
43 OPTION EPILOGUE:None	51 OPTION EPILOGUE:None

44	52

45 mov edx, DWORD PTR [esp + 4]	53 mov edx, DWORD PTR [esp + 4]

46 mov eax, [edx]	54 mov eax, [edx]

47 mov FS:[0], eax	55 mov FS:[0], eax

48 ret 4	56 ret 4

49	57

50 UnregisterExceptionRecord ENDP	58 UnregisterExceptionRecord ENDP

51	59

52 END	60 END

OLD	NEW

« chrome_frame/exception_barrier.cc ('K') | « chrome_frame/exception_barrier.cc ('k') | chrome_frame/test/exception_barrier_unittest.cc » ('j') | no next file with comments »