Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Issue 17478: Resubmit r7826 after fixing breakages:... (Closed)

Created:
11 years, 11 months ago by sgk
Modified:
9 years, 5 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Resubmit r7826 after fixing breakages: Generation of net .vcproj and .sln files. Specific changes: * Add to MSVSProject() calls: GUID, input_files list, tools list (that are common to the individual configurations). * Add *.h files and MSVSFilter() hierarchies to input_files lists. * Switch to using the .Remove() method for instead of by-hand Python to remove things from input_files lists. * Use of precompiled header files still requires separate by-hand Configuration specifications. * Remove .dat files from the input file lists when compiling. * Extensive _Node_MSVS.py changes that set us up for deducing this information from parallel Debug and Release builds instead of configuring things by hand, basically by delaying evaluation of most of the strings, then introspecting on the command lines that will be used to generate the targets and translating compiler and linker options into Visual Studio settings. The result is (again) byte-for-byte identical .vcproj files, modulo removal of a ".\" current-directory prefix for a few RelativePath specifications. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7854

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1121 lines, -208 lines) Patch
M net/crash_cache.scons View 1 chunk +56 lines, -10 lines 0 comments Download
M net/dump_cache.scons View 1 chunk +54 lines, -9 lines 0 comments Download
M net/net_lib.scons View 6 chunks +311 lines, -55 lines 0 comments Download
M net/net_perftests.scons View 1 chunk +73 lines, -15 lines 0 comments Download
M net/net_unittests.scons View 2 chunks +162 lines, -49 lines 0 comments Download
M net/stress_cache.scons View 1 chunk +55 lines, -10 lines 0 comments Download
M net/tools/tld_cleanup/tld_cleanup.scons View 1 chunk +54 lines, -9 lines 0 comments Download
M site_scons/site_tools/_Node_MSVS.py View 20 chunks +352 lines, -49 lines 0 comments Download
M site_scons/site_tools/chromium_builders.py View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
sgk
11 years, 11 months ago (2009-01-10 17:53:06 UTC) #1
TBR based on:  1) previous approval; 2) try server result; 3) Saturday
monitoring and roll-back if it breaks again.

Powered by Google App Engine
This is Rietveld 408576698