remove the logic to compute enable_gles since it's broken;...

remove the logic to compute enable_gles since it's broken;
add enable_eglimage

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45889

[wjia(left Chromium), 2010-04-28 23:52:29]

Looks that arm+linux+chromeos doesn't deduce enable_gles. So I just set the
default to enable_gles=0. User can always override it throught GYP_DEFINES or
include.gypi.

Also added enable_eglimage. Based on current vendor situation, I can't use
enable_gles for eglimage support.

[piman, 2010-04-29 00:05:03]

LGTM except for one thing.

http://codereview.chromium.org/1747019/diff/2001/3001
File build/common.gypi (right):

http://codereview.chromium.org/1747019/diff/2001/3001#newcode253
build/common.gypi:253: # is not correct for enable_gles. Just set default here.
No need for that comment, please remove.

[wjia(left Chromium), 2010-04-29 00:15:44]

Done. Could you help me check in? :-)
Thanks,
Wei

On 2010/04/29 00:05:03, piman wrote:
> LGTM except for one thing.
> 
> http://codereview.chromium.org/1747019/diff/2001/3001
> File build/common.gypi (right):
> 
> http://codereview.chromium.org/1747019/diff/2001/3001#newcode253
> build/common.gypi:253: # is not correct for enable_gles. Just set default
here.
> No need for that comment, please remove.

[piman, 2010-04-29 00:19:55]

On Wed, Apr 28, 2010 at 5:15 PM, <wjia@chromium.org> wrote:

> Done. Could you help me check in? :-)
> Thanks,
> Wei


Pushed.

Antoine


>
> On 2010/04/29 00:05:03, piman wrote:
>
>> LGTM except for one thing.
>>
>
>  http://codereview.chromium.org/1747019/diff/2001/3001
>> File build/common.gypi (right):
>>
>
>  http://codereview.chromium.org/1747019/diff/2001/3001#newcode253
>> build/common.gypi:253: # is not correct for enable_gles. Just set default
>>
> here.
>
>> No need for that comment, please remove.
>>
>
>
>
> http://codereview.chromium.org/1747019/show
>