Issue 1747018: Added cacheinvalidation.gyp to build/all.gyp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1747018: Added cacheinvalidation.gyp to build/all.gyp. (Closed)

Created:
10 years, 8 months ago by akalin

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain, ncarter (slow)

CC:
chromium-reviews

Visibility:
Public.

Added cacheinvalidation.gyp to build/all.gyp. BUG=34646 TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46030

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -2 lines)			Patch
	M	build/all.gyp	View		7 chunks	+7 lines, -0 lines	0 comments	Download
	M	third_party/cacheinvalidation/cacheinvalidation.gyp	View	1	4 chunks	+8 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

akalin

On 2010/04/28 01:51:45, akalin wrote: > +nick for review Looks like there are legit win/linux ...

10 years, 8 months ago (2010-04-28 03:52:40 UTC) #2

akalin

Okay, PTAL. On 2010/04/28 03:52:40, akalin wrote: > On 2010/04/28 01:51:45, akalin wrote: > > ...

10 years, 7 months ago (2010-04-29 02:06:52 UTC) #3

ncarter (slow)

Tentatively LGTM but I'd like nsylvain to double check the appropriateness of the dependencies in ...

10 years, 7 months ago (2010-04-29 02:18:13 UTC) #4

lgtm