Changing access to scoped_refptr member variables from private to protected....

Changing access to scoped_refptr member variables from private to protected.
This is required to be able to extend the functionality of the class where existing public functionality does not offer sufficient access.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7851

[M-A Ruel, 2009-01-09 21:46:44]

Remove the extra stuff I commented below and lgtm.

http://codereview.chromium.org/17464/diff/201/202
File base/ref_counted.h (right):

http://codereview.chromium.org/17464/diff/201/202#newcode228
Line 228: // of members.
I think the comment is unnecessary. As far as for people who knows C++.... :)

http://codereview.chromium.org/17464/diff/201/203
File base/ref_counted_unittest.cc (right):

http://codereview.chromium.org/17464/diff/201/203#newcode31
Line 31: TEST(RefCountedUnitTest, ScopedRefPtrMemberAccess) {
I'm pretty sure this is in fact unnecessary since the class SelfAssign is not a
template. So please remove it.

[tommi (sloooow) - chröme, 2009-01-09 21:53:35]

removed the comment.  adding it here so it stays with the cl description.

 // Use |protected| and not |private| for member variables so
 // that derived classes have full access to member variables
 // and can add features that e.g. depend on getting the address
 // of members.

http://codereview.chromium.org/17464/diff/201/202
File base/ref_counted.h (right):

http://codereview.chromium.org/17464/diff/201/202#newcode228
Line 228: // of members.
yup... I guess this more belongs in the cl description since I will get asked
about it. :)

removed.

http://codereview.chromium.org/17464/diff/201/203
File base/ref_counted_unittest.cc (right):

http://codereview.chromium.org/17464/diff/201/203#newcode31
Line 31: TEST(RefCountedUnitTest, ScopedRefPtrMemberAccess) {
the purpose of this test if we can call it that is to make sure that if someone
goes ahead and changes access to the member variable back to private, this test
will break the build.  I just picked SelfAssign since it's already here... I
just needed something that had AddRef and Release.

I'll remove it if you still want me to.

[M-A Ruel, 2009-01-09 21:57:53]

On 2009/01/09 21:53:35, tommi wrote:
> I'll remove it if you still want me to.

That's fine, lgtm as-is.

[cpu_(ooo_6.6-7.5), 2009-01-09 23:18:47]

lgtm


On 2009/01/09 21:57:53, M-A wrote:
> On 2009/01/09 21:53:35, tommi wrote:
> > I'll remove it if you still want me to.
> 
> That's fine, lgtm as-is.