src/x64/ic-x64.cc - Issue 174639: Use a root array register for constant loads and stack guards on x64....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/ic-x64.cc

Issue 174639: Use a root array register for constant loads and stack guards on x64.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 11 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/ic-x64.cc

===================================================================

--- src/x64/ic-x64.cc (revision 2780)

+++ src/x64/ic-x64.cc (working copy)

@@ -339,7 +339,7 @@

__ bind(&fast);

__ movq(rax, Operand(rcx, rax, times_pointer_size,

FixedArray::kHeaderSize - kHeapObjectTag));

- __ Cmp(rax, Factory::the_hole_value());

+ __ CompareRoot(rax, Heap::kTheHoleValueRootIndex);

// In case the loaded value is the_hole we have to consult GetProperty

// to ensure the prototype chain is searched.

__ j(equal, &slow);

@@ -613,9 +613,9 @@

// Check for boolean.

__ bind(&non_string);

- __ Cmp(rdx, Factory::true_value());

+ __ CompareRoot(rdx, Heap::kTrueValueRootIndex);

__ j(equal, &boolean);

- __ Cmp(rdx, Factory::false_value());

+ __ CompareRoot(rdx, Heap::kFalseValueRootIndex);

__ j(not_equal, &miss);

__ bind(&boolean);

StubCompiler::GenerateLoadGlobalFunctionPrototype(

« no previous file with comments | « src/x64/codegen-x64.cc ('k') | src/x64/macro-assembler-x64.h » ('j') | no next file with comments »