Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Issue 174639: Use a root array register for constant loads and stack guards on x64.... (Closed)

Created:
11 years, 3 months ago by Erik Corry
Modified:
9 years, 7 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Use a root array register for constant loads and stack guards on x64. This only wins us around 1% in performance, but it makes the code more compact. We don't currently have a way to represent in the virtual frame that a slot contains a value from the root array. Adding this would probably make the code more compact.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -110 lines) Patch
M src/heap.h View 4 chunks +14 lines, -13 lines 0 comments Download
M src/heap.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M src/x64/builtins-x64.cc View 8 chunks +14 lines, -11 lines 0 comments Download
M src/x64/cfg-x64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/x64/codegen-x64.cc View 30 chunks +36 lines, -51 lines 0 comments Download
M src/x64/ic-x64.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 4 chunks +20 lines, -4 lines 0 comments Download
M src/x64/register-allocator-x64.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/x64/register-allocator-x64-inl.h View 2 chunks +10 lines, -10 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M src/x64/virtual-frame-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/virtual-frame-x64.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
11 years, 3 months ago (2009-08-28 12:25:56 UTC) #1
William Hesse
11 years, 3 months ago (2009-08-31 07:55:43 UTC) #2
Looks really nice to me.

Powered by Google App Engine
This is Rietveld 408576698