Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 174605: Added 64-bit Windows build through SCons (Closed)

Created:
11 years, 3 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Added 64-bit Windows build through SCons. The SCons build now supports building for 64-bit Windows. This still requires that the SCons build is passed an env parameter containing the PATH and LIB for the 64-bit build as SCons autodetects the 32-bit environment. Lowered the warning level for the 64-bit build temporarily. Added a verbose option to SCons to display the startup banner for the Microsoft Visual C++ tools. Committed: http://code.google.com/p/v8/source/detail?r=2774

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -16 lines) Patch
M SConstruct View 6 chunks +42 lines, -14 lines 0 comments Download
M test/cctest/test-log-stack-tracer.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
11 years, 3 months ago (2009-08-27 12:58:09 UTC) #1
William Hesse
11 years, 3 months ago (2009-08-27 13:11:21 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698