Issue 1746013: Make sure to check for in-progress downloads when quitting. Adds back in code...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1746013: Make sure to check for in-progress downloads when quitting. Adds back in code... (Closed)

Created:
10 years, 8 months ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Make sure to check for in-progress downloads when quitting. Adds back in code removed during quit refactoring. BUG=41675 TEST=quit while downloading, can cancel and quit app, as well as cancel the quit to allow the download to complete. When download completes, closing all windows shouldn't quit (normal behavior). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45832

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	chrome/browser/app_controller_mac.mm	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages