Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 174600: Add allocation support to ia32 macro assembler (Closed)

Created:
11 years, 3 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add allocation support to ia32 macro assembler. Factored out the allocation in new space from assembler code into the macro assembler. To support the current allocation patterns a number of different functions where required. This is change is identical to http://codereview.chromium.org/174524 (committed in r2768 and reverted in r2769) except that line 710 in macro-assembler-ia32.cc is cmp(result_end, Operand::StaticVariable(new_space_allocation_limit)); instead of cmp(result, Operand::StaticVariable(new_space_allocation_limit)); and pre-submit fixes as well. TBR=ager@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=2771

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -38 lines) Patch
M src/ia32/builtins-ia32.cc View 4 chunks +10 lines, -15 lines 0 comments Download
M src/ia32/codegen-ia32.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 1 chunk +9 lines, -12 lines 0 comments Download
M src/ia32/codegen-ia32-inl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 2 chunks +49 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +140 lines, -0 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 2 chunks +3 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
11 years, 3 months ago (2009-08-27 09:08:03 UTC) #1
Mads Ager (chromium)
11 years, 3 months ago (2009-08-27 09:08:51 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698