Issue 174585: Draw background of Linux extension toolstrips.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 174585: Draw background of Linux extension toolstrips. (Closed)

Created:
11 years, 4 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
Erik does not do reviews, Elliot Glaysher

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Draw background of Linux extension toolstrips. This makes Linux extension shelf quite pretty now IMHO. TEST=Just see it. http://crbug.com/16759 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24605

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -0 lines)			Patch
M	chrome/browser/gtk/extension_shelf_gtk.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/extension_shelf_gtk.cc	View	3 chunks	+17 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/extension_view_gtk.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/extension_view_gtk.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_gtk.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_gtk.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Paweł Hajdan Jr.

Please review: erg: GTK parts erikkay: extension parts

11 years, 4 months ago (2009-08-26 23:56:40 UTC) #1

Elliot Glaysher

On 2009/08/26 23:56:40, Paweł Hajdan Jr. wrote: > Please review: > > erg: GTK parts ...

11 years, 4 months ago (2009-08-26 23:59:10 UTC) #2

LGTM