Fix theme caching on Vista 64 when default theme is installed from the theme ...

Fix theme caching on Vista 64 when default theme is installed from the theme gallery.

BUG= http://crbug.com/20344
TEST= On vista 64 , install a non-default theme.  Open theme gallery and choose "Classic" theme.  Close browser and restart.  Theme should be default aero theme on Vista, and not the opaque blue windows theme.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24709

[Miranda Callahan, 2009-08-26 21:41:03]

When "SetTheme" is called with the default theme, it writes a bunch of images to
disk, and the prefs file.  Under Vista, this causes
BrowserThemeProvider::ShouldUseNativeFrame to give the wrong answer when we
reopen the browser, as it finds a custom frame image in the cached set of
images, and thus answers "no" -- causing the glass theme to not be loaded.

If the "classic theme" is to be identical to the "default theme" in all cases,
this code can be changed to just check for extension name; that way the code
path will be identical for both "install classic" in the gallery and "restore
default" in the options dialog.

[Glen Murphy, 2009-08-27 04:02:17]

Themes may wish to use the native frame without having to be called 'default' -
the ShouldUseNative frame check should continue to just check HasCustomImage for
IDR_THEME_FRAME (or whatever it's called) - we shouldn't be generating frame
images in the case where no frame image is supplied, as our default theme.dll
already supplies those images (plus it becomes brittle for when we update them).

[Miranda Callahan, 2009-08-27 21:58:33]

On 2009/08/27 04:02:17, Glen Murphy wrote:
> Themes may wish to use the native frame without having to be called 'default'
-
> the ShouldUseNative frame check should continue to just check HasCustomImage
for
> IDR_THEME_FRAME (or whatever it's called) - we shouldn't be generating frame
> images in the case where no frame image is supplied, as our default theme.dll
> already supplies those images (plus it becomes brittle for when we update
them).

Much nicer code, then.  "PTAL."

[Miranda Callahan, 2009-08-27 23:39:59]

New version.  The logic here is that a custom frame image or any frame (or
background tab) tinting will trigger wholescale tinting and caching of the frame
and tab image set; the absence of all of these means that we rely on the default
set, with no caching at all.

[Glen Murphy, 2009-08-27 23:49:49]

LGTM.