Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 174522: Use stack frame marker constants to mark arguments adaptor frame. (Closed)

Created:
11 years, 4 months ago by William Hesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Use stack frame marker constants to mark arguments adaptor frame. Committed: http://code.google.com/p/v8/source/detail?r=2770

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -37 lines) Patch
M src/arm/builtins-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/codegen-arm.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M src/frames.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/frames-inl.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/codegen-ia32.cc View 6 chunks +10 lines, -9 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/codegen-x64.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M src/x64/frames-x64.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
William Hesse
Simplified much more. It would be even simpler if we marked the frames in 1 ...
11 years, 4 months ago (2009-08-26 13:44:05 UTC) #1
Mads Ager (chromium)
11 years, 4 months ago (2009-08-26 15:01:07 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698