Issue 174517: * Make stack/preemption guard faster on ARM by putting stack...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 174517: * Make stack/preemption guard faster on ARM by putting stack... (Closed)

Created:
11 years, 4 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

* Make stack/preemption guard faster on ARM by putting stack limit in the roots array. Committed: http://code.google.com/p/v8/source/detail?r=2760

Patch Set 1 #

Total comments: 4

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -15 lines)			Patch
M	src/arm/codegen-arm.cc	View	2 chunks	+3 lines, -7 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/arm/virtual-frame-arm.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/execution.h	View	4 chunks	+9 lines, -1 line	1 comment	Download
M	src/execution.cc	View	3 chunks	+5 lines, -2 lines	0 comments	Download
M	src/heap.h	View	2 chunks	+7 lines, -1 line	1 comment	Download
M	src/heap.cc	View	1 chunk	+9 lines, -0 lines	2 comments	Download
M	src/v8.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

11 years, 4 months ago (2009-08-26 10:09:28 UTC) #2

LGTM!

http://codereview.chromium.org/174517/diff/1/10
File src/execution.h (right):

http://codereview.chromium.org/174517/diff/1/10#newcode229
Line 229: : initial_jslimit_(kIllegalLimit),
I know this has not been introduced in this change, but could you change this to
a four space indent.

http://codereview.chromium.org/174517/diff/1/2
File src/heap.cc (right):

http://codereview.chromium.org/174517/diff/1/2#newcode3260
Line 3260: // Set up the special root array entry is the stack guard.
is -> containing?

http://codereview.chromium.org/174517/diff/1/2#newcode3263
Line 3263: limit |= kSmiTag;
Do you need this?  You should be able to remove the explicit bit-fiddling here.

http://codereview.chromium.org/174517/diff/1/8
File src/heap.h (right):

http://codereview.chromium.org/174517/diff/1/8#newcode231
Line 231: // Sets the stack limit in the in the roots_ array.  Some
architectures
in the in the -> in the

Expand Messages | Collapse Messages