Issue 174513: Add isVisible parameter to WebPlugin::updateGeometry....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 174513: Add isVisible parameter to WebPlugin::updateGeometry.... (Closed)

Created:
11 years, 4 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add isVisible parameter to WebPlugin::updateGeometry. This allows for geometry updates while the plugin is hidden so that when it becomes visible, the plugin is properly positioned. In this change, I also revised RenderWidget::SchedulePluginMove to properly merge a move that only updates the visible state, and I fixed up TestShell to properly handle moves that only update the visible state. R=jam BUG=19888, 20260 TEST=covered by layout tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24457

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -19 lines)			Patch
M	chrome/renderer/render_widget.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	webkit/api/public/WebPlugin.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/api/src/WebPluginContainerImpl.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/glue/webplugin_impl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/webplugin_impl.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/tools/layout_tests/test_expectations.txt	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate_win.cc	View	1 chunk	+15 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages