Make a new yes/no messagebox wrapper function, use it in the bookmark alert....

chrome/browser/bookmarks/bookmark_utils.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/bookmarks/bookmark_utils.h"
 
 #include "app/clipboard/clipboard.h"
 #include "app/drag_drop_types.h"
 #include "app/l10n_util.h"
 #include "app/tree_node_iterator.h"
 #include "base/basictypes.h"
 #include "base/file_path.h"
 #include "base/string_util.h"
 #include "base/string16.h"
 #include "base/time.h"
 #include "chrome/browser/bookmarks/bookmark_drag_data.h"
 #include "chrome/browser/bookmarks/bookmark_model.h"
 #if defined(OS_MACOSX)
 #include "chrome/browser/bookmarks/bookmark_pasteboard_helper_mac.h"
 #endif
 #include "chrome/browser/browser.h"
 #include "chrome/browser/browser_list.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/browser_window.h"
 #include "chrome/browser/history/query_parser.h"
+#include "chrome/browser/platform_util.h"
 #include "chrome/browser/pref_service.h"
 #include "chrome/browser/profile.h"
 #include "chrome/browser/tab_contents/page_navigator.h"
 #include "chrome/browser/tab_contents/tab_contents.h"
 #include "chrome/common/notification_service.h"
 #include "chrome/common/pref_names.h"
 #include "grit/app_strings.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "net/base/net_util.h"
@@ skipping 121 matching lines @@
 }
 
 bool ShouldOpenAll(gfx::NativeWindow parent,
                    const std::vector<const BookmarkNode*>& nodes) {
   int descendant_count = 0;
   for (size_t i = 0; i < nodes.size(); ++i)
     descendant_count += DescendantURLCount(nodes[i]);
   if (descendant_count < bookmark_utils::num_urls_before_prompting)
     return true;
 
-  // Bug 40011: we should refactor this into a cross-platform "prompt before
-  // continuing" function.
-#if defined(OS_WIN)
-  std::wstring message =
-      l10n_util::GetStringF(IDS_BOOKMARK_BAR_SHOULD_OPEN_ALL,
-                            IntToWString(descendant_count));
-  return MessageBox(parent, message.c_str(),
-                    l10n_util::GetString(IDS_PRODUCT_NAME).c_str(),
-                    MB_YESNO | MB_ICONWARNING | MB_TOPMOST) == IDYES;
-#elif defined(TOOLKIT_GTK)
-  std::string message = l10n_util::GetStringFUTF8(
+  string16 message = l10n_util::GetStringFUTF16(
       IDS_BOOKMARK_BAR_SHOULD_OPEN_ALL,
       IntToString16(descendant_count));
-  GtkWidget* dialog = gtk_message_dialog_new(parent,
-      static_cast<GtkDialogFlags>(
-          GTK_DIALOG_MODAL | GTK_DIALOG_DESTROY_WITH_PARENT),
-      GTK_MESSAGE_QUESTION,
-      GTK_BUTTONS_YES_NO,
-      "%s", message.c_str());
-  gtk_util::ApplyMessageDialogQuirks(dialog);
-  gtk_window_set_title(GTK_WINDOW(dialog),
-                       l10n_util::GetStringUTF8(IDS_PRODUCT_NAME).c_str());
-  gint result = gtk_dialog_run(GTK_DIALOG(dialog));
-  gtk_widget_destroy(dialog);
-  return (result == GTK_RESPONSE_YES);
-#else
-  // TODO(port): Display a dialog prompt.
-  // http://crbug.com/34481
-  NOTIMPLEMENTED();
-  return true;
-#endif
+  string16 title = l10n_util::GetStringUTF16(IDS_PRODUCT_NAME);
+  return platform_util::SimpleYesNoBox(parent, title, message);
 }
 
 // Comparison function that compares based on date modified of the two nodes.
 bool MoreRecentlyModified(const BookmarkNode* n1, const BookmarkNode* n2) {
   return n1->date_group_modified() > n2->date_group_modified();
 }
 
 // Returns true if |text| contains each string in |words|. This is used when
 // searching for bookmarks.
 bool DoesBookmarkTextContainWords(const string16& text,
@@ skipping 143 matching lines @@
                    const std::vector<const BookmarkNode*>& nodes,
                    gfx::NativeView view) {
   DCHECK(!nodes.empty());
 
 #if defined(TOOLKIT_VIEWS)
   // Set up our OLE machinery
   OSExchangeData data;
   BookmarkDragData drag_data(nodes);
   drag_data.Write(profile, &data);
 
-  views::RootView* root_view = views::Widget::GetWidgetFromNativeView(view)->GetRootView();
+  views::RootView* root_view =
+      views::Widget::GetWidgetFromNativeView(view)->GetRootView();
 
   // Allow nested message loop so we get DnD events as we drag this around.
   bool was_nested = MessageLoop::current()->IsNested();
   MessageLoop::current()->SetNestableTasksAllowed(true);
 
   root_view->StartDragForViewFromMouseEvent(NULL, data,
       DragDropTypes::DRAG_COPY | DragDropTypes::DRAG_MOVE |
       DragDropTypes::DRAG_LINK);
 
   MessageLoop::current()->SetNestableTasksAllowed(was_nested);
@@ skipping 304 matching lines @@
       }
     } else {
       *index = real_parent->GetChildCount();
     }
   }
 
   return real_parent;
 }
 
 }  // namespace bookmark_utils