Make a new yes/no messagebox wrapper function, use it in the bookmark alert....

Make a new yes/no messagebox wrapper function, use it in the bookmark alert.

Recommitting of r46101.

BUG=http://crbug.com/34481; http://crbug.com/40011
TEST=on Mac/ChromeOS, have at least 15 bookmarks on bookmarks bar or other bookmarks,
right click on one of those and click on Open all bookmarks. A confirmation
dialog box should be shown. No other visible change.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50894

[Avi (use Gerrit), 2010-04-30 20:25:47]

Since I was getting an error that the dialog needed to be "realized to compute
font metrics correctly", I moved the measurements to after the display. The one
concern that I have is that I threw a gtk_widget_show_all before gtk_dialog_run.
Is that safe?

[Evan Stade, 2010-05-01 01:03:37]

sorry for missing this. Guess it is a Debug-only check that is failing.

http://codereview.chromium.org/1745024/diff/1/2
File chrome/browser/platform_util_common_linux.cc (right):

http://codereview.chromium.org/1745024/diff/1/2#newcode62
chrome/browser/platform_util_common_linux.cc:62: gtk_widget_show_all(dialog);
I suspect this is ok, but the following seems a little better to me:

  gtk_widget_realize(dialog);
  AdjustDialogTitle(dialog);
  [run or show]

http://codereview.chromium.org/1745024/diff/1/2#newcode76
chrome/browser/platform_util_common_linux.cc:76: AdjustDialogTitle(dialog)
; on the end

[Avi (use Gerrit), 2010-05-02 00:35:19]

OK. I think this is passing the trybots now.

[Avi (use Gerrit), 2010-05-03 15:14:52]

On 2010/05/02 00:35:19, Avi wrote:
> OK. I think this is passing the trybots now.

And... it's not. We're timing out on BookmarkBarViewTest12.CloseWithModalDialog
on linux_chromeos and linux_views, though plain linux doesn't have that issue.
Whee.

[Avi (use Gerrit), 2010-06-24 23:23:56]

Evan-

Can you give this a once over (again)? This is tested to work on the CrOS
version of Chrome, but the unittest is failing and I can't diagnose it because
it's broken unrelatedly. I filed a bug against it, but I want to get this
feature in... :O

[Evan Stade, 2010-06-25 01:02:35]

lgtm!

http://codereview.chromium.org/1745024/diff/44002/55004
File chrome/browser/platform_util_common_linux.cc (right):

http://codereview.chromium.org/1745024/diff/44002/55004#newcode107
chrome/browser/platform_util_common_linux.cc:107: return (g_dialog_response ==
GTK_RESPONSE_YES);
nit: no ()