Issue 1745018: Clean up initial CA layer setup for Mac Plugins

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1745018: Clean up initial CA layer setup for Mac Plugins (Closed)

Created:
10 years, 8 months ago by stuartmorgan

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews, pam+watch_chromium.org, jam, darin-cc_chromium.org, John Grabowski, viettrungluu

Visibility:
Public.

Description

Clean up initial CA layer setup for Mac Plugins UpdateAcceleratedSurface and DrawLayerInSurface don't make sense before windowed_handle has been set, so tweak the way we handle initialization of CA plugins. BUG=none TEST=CA plugins should still work Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45828

Patch Set 1 #

Patch Set 2 : Tweak initialization order a bit more #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -10 lines)			Patch
	M	webkit/glue/plugins/webplugin_delegate_impl.h	View		1 chunk	+1 line, -4 lines	0 comments	Download
	M	webkit/glue/plugins/webplugin_delegate_impl_mac.mm	View	1	4 chunks	+16 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

stuartmorgan

Doesn't actually fix the white-plugin issues, but it's more clearly correct this way.

10 years, 8 months ago (2010-04-28 17:12:39 UTC) #1

lgtm

Expand Messages | Collapse Messages