Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 1745009: Changes GetSVNBranch to prefer origin/HEAD over all others. (Closed)

Created:
10 years, 8 months ago by sky
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin, M-A Ruel
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Changes GetSVNBranch to prefer origin/HEAD over all others. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45468

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M scm.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sky
10 years, 8 months ago (2010-04-23 17:22:30 UTC) #1
Evan Martin
ok (remind me again why you have to implement all of this twice?)
10 years, 8 months ago (2010-04-23 17:27:50 UTC) #2
sky
On Fri, Apr 23, 2010 at 10:27 AM, <evan@chromium.org> wrote: > ok (remind me again ...
10 years, 8 months ago (2010-04-23 17:33:14 UTC) #3
M-A Ruel
Organic growth, please refactor.
10 years, 8 months ago (2010-04-23 17:36:44 UTC) #4
sky
10 years, 8 months ago (2010-04-23 17:54:41 UTC) #5
I'm going to land this now. When I have time to sharpen my python
skills I'll see about refactoring.

  -Scott

On Fri, Apr 23, 2010 at 10:36 AM,  <maruel@chromium.org> wrote:
> Organic growth, please refactor.
>
> http://codereview.chromium.org/1745009/show
>

Powered by Google App Engine
This is Rietveld 408576698