Changing the mediaplayer so it starts over when the clip is finished.

Changing the mediaplayer so it starts over when the clip is finished.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46009

[xiyuan, 2010-04-21 19:20:48]

LGTM

[arv (Not doing code reviews), 2010-04-21 19:59:46]

drive by review

http://codereview.chromium.org/1745004/diff/1/2
File chrome/browser/resources/mediaplayer.html (right):

http://codereview.chromium.org/1745004/diff/1/2#newcode272
chrome/browser/resources/mediaplayer.html:272: z-index: 9999;
You should probably refactor these to share a class name. It seems like all your
icons have "z-index: 999; width: 100%; height: 100%"

An element can have multiple class names (whitespace separated).

http://codereview.chromium.org/1745004/diff/1/2#newcode345
chrome/browser/resources/mediaplayer.html:345: background:
-webkit-gradient(linear,
repeated code. Please collapse:

.nextbutton:hover,
.playlistbutton:hover {
  ...
}

Or better yet use a shared class for these icons and use ID to identify the
unique ones.

[dhg, 2010-04-26 19:18:13]

Took arv's advice and re factored a bit.

On 2010/04/21 19:59:46, arv wrote:
> drive by review
> 
> http://codereview.chromium.org/1745004/diff/1/2
> File chrome/browser/resources/mediaplayer.html (right):
> 
> http://codereview.chromium.org/1745004/diff/1/2#newcode272
> chrome/browser/resources/mediaplayer.html:272: z-index: 9999;
> You should probably refactor these to share a class name. It seems like all
your
> icons have "z-index: 999; width: 100%; height: 100%"
> 
> An element can have multiple class names (whitespace separated).
> 
> http://codereview.chromium.org/1745004/diff/1/2#newcode345
> chrome/browser/resources/mediaplayer.html:345: background:
> -webkit-gradient(linear,
> repeated code. Please collapse:
> 
> .nextbutton:hover,
> .playlistbutton:hover {
>   ...
> }
> 
> Or better yet use a shared class for these icons and use ID to identify the
> unique ones.

[xiyuan, 2010-04-29 23:19:21]

LGTM