Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: samples/o3d-webgl/file_request.js

Issue 1745002: Incremental progress toward archive loading in o3d-webgl. Implemented... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/o3d/
Patch Set: Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « samples/o3d-webgl/base.js ('k') | samples/o3d-webgl/pack.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: samples/o3d-webgl/file_request.js
===================================================================
--- samples/o3d-webgl/file_request.js (revision 45126)
+++ samples/o3d-webgl/file_request.js (working copy)
@@ -187,6 +187,10 @@
o3d.FileRequest.prototype.open =
function(method, uri, async) {
this.uri = uri;
+ // TODO(petersont): I think there is a race condition here -- calling
+ // code expects that it can still set up the onreadystatechange callback
+ // between open() and send(), but if open() actually initiates the XHR
+ // then the caller may miss the crucial completion callback!
if (this.isImageUrl_(uri)) {
this.image_ = new Image();
var that = this;
« no previous file with comments | « samples/o3d-webgl/base.js ('k') | samples/o3d-webgl/pack.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698