Issue 174490: Fix cases that initialized StringTokenizer with a temporary.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 174490: Fix cases that initialized StringTokenizer with a temporary. (Closed)

Created:
11 years, 4 months ago by mattm

Modified:
9 years, 7 months ago

Reviewers:
Mike Mammarella, Paweł Hajdan Jr.

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix cases that initialized StringTokenizer with a temporary. Fix examples in StringTokenizer header that recommended doing that. BUG=none TEST=on linux, open options, click proxy configuration button a bunch. It should not fail intermittently. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24398

Patch Set 1 #

Patch Set 2 : check for null path #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -4 lines)			Patch
M	base/string_tokenizer.h	View		3 chunks	+13 lines, -2 lines	0 comments	Download
M	chrome/browser/gtk/options/advanced_contents_gtk.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/shell_integration_linux.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages