Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: chrome/common/render_messages_internal.h

Issue 174484: Add a nullable string16 class to base. It combines a string16 + a null param... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/render_messages_internal.h
===================================================================
--- chrome/common/render_messages_internal.h (revision 24540)
+++ chrome/common/render_messages_internal.h (working copy)
@@ -13,6 +13,7 @@
#include "base/clipboard.h"
#include "base/file_path.h"
+#include "base/nullable_string16.h"
#include "base/platform_file.h"
#include "base/gfx/rect.h"
#include "base/gfx/native_widget_types.h"
@@ -1597,20 +1598,16 @@
unsigned /* length */)
// Get a the ith key within a storage area.
- IPC_SYNC_MESSAGE_CONTROL2_2(ViewHostMsg_DOMStorageKey,
+ IPC_SYNC_MESSAGE_CONTROL2_1(ViewHostMsg_DOMStorageKey,
int64 /* storage_area_id */,
unsigned /* index */,
- string16 /* key */,
- bool /* key_is_null */)
+ NullableString16 /* key */)
// Get a value based on a key from a storage area.
- // TODO(jorlow): Convert value + value_is_null over to a NullableString16
- // once http://crbug.com/17343 is completed.
- IPC_SYNC_MESSAGE_CONTROL2_2(ViewHostMsg_DOMStorageGetItem,
+ IPC_SYNC_MESSAGE_CONTROL2_1(ViewHostMsg_DOMStorageGetItem,
int64 /* storage_area_id */,
string16 /* key */,
- string16 /* value */,
- bool /* value_is_null */)
+ NullableString16 /* value */)
// Set a value that's associated with a key in a storage area.
IPC_MESSAGE_CONTROL3(ViewHostMsg_DOMStorageSetItem,
« no previous file with comments | « chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc ('k') | chrome/renderer/renderer_webstoragearea_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698