Issue 174482: Use ftruncate() instead of fwrite() to extend files....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 174482: Use ftruncate() instead of fwrite() to extend files.... (Closed)

Created:
11 years, 4 months ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, agl

CC:
chromium-reviews_googlegroups.com, John Grabowski, brettw

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Use ftruncate() instead of fwrite() to extend files. BUG=20249 TEST=Browser still works Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24451

Patch Set 1 #

Total comments: 2

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -18 lines)			Patch
	M	base/shared_memory_posix.cc	View		2 chunks	+3 lines, -18 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

pink (ping after 24hrs)

I'm not certain the seek is necessary, but better safe than sorry?

11 years, 4 months ago (2009-08-26 01:18:11 UTC) #1

Mark Mentovai

I think that the seek is unnecessary, but LGTM either way. http://codereview.chromium.org/174482/diff/1/2 File base/shared_memory_posix.cc (right): ...

11 years, 4 months ago (2009-08-26 01:22:51 UTC) #2

pink (ping after 24hrs)

11 years, 4 months ago (2009-08-26 15:16:57 UTC) #4

http://codereview.chromium.org/174482/diff/1/2
File base/shared_memory_posix.cc (right):

http://codereview.chromium.org/174482/diff/1/2#newcode199
Line 199: size_t current_size = 0;
On 2009/08/26 01:22:51, Mark Mentovai wrote:
> While you're here, move the declaration down to where it's actually used.

Done.

Expand Messages | Collapse Messages