Send content settings based on the URL to the renderer instead of just the host.

Send content settings based on the URL to the renderer instead of just the host.

BUG=36025
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45424

[jochen (gone - plz use gerrit), 2010-04-21 09:10:30]

please review.

When you use the content blocked bubble to allow e.g. images and the URL doesn't
have a hostname, it will add the complete URL as pattern (which works)

[Peter Kasting, 2010-04-21 18:01:50]

LGTM

http://codereview.chromium.org/1744003/diff/2001/3002
File chrome/browser/renderer_host/async_resource_handler.cc (right):

http://codereview.chromium.org/1744003/diff/2001/3002#newcode123
chrome/browser/renderer_host/async_resource_handler.cc:123: host,
context->host_zoom_map()->GetZoomLevel(host)));
Eventually we want Zoom to do the same thing, but that's probably a large change
(as I suspect we have to change the zoom map too), so if you're feeling
super-generous feel free to add that in, but otherwise this is fine.

[jochen (gone - plz use gerrit), 2010-04-21 18:18:45]

On 2010/04/21 18:01:50, Peter Kasting wrote:
> LGTM
> 
> http://codereview.chromium.org/1744003/diff/2001/3002
> File chrome/browser/renderer_host/async_resource_handler.cc (right):
> 
> http://codereview.chromium.org/1744003/diff/2001/3002#newcode123
> chrome/browser/renderer_host/async_resource_handler.cc:123: host,
> context->host_zoom_map()->GetZoomLevel(host)));
> Eventually we want Zoom to do the same thing, but that's probably a large
change
> (as I suspect we have to change the zoom map too), so if you're feeling
> super-generous feel free to add that in, but otherwise this is fine.


I started implementing this, however, the following issue arised: If you zoom
e.g. file:///tmp/test.html, can we really assume that you also want to zoom all
other file: tabs?

In contrast, when you zoom google.com/something, then you probably also want to
zoom google.com/something/else.

So I concluded that for zooming, we really want this to be host based.

[Peter Kasting, 2010-04-21 18:33:33]

On 2010/04/21 18:18:45, jochen wrote:
> I started implementing this, however, the following issue arised: If you zoom
> e.g. file:///tmp/test.html, can we really assume that you also want to zoom
all
> other file: tabs?

Eh?  If the implementation is "for URLs lacking a host, use the full spec", then
if we zoom "file:///tmp/test.html", that will only affect that file, no other
filenames.  That's also the effect you should see with content blocking --
blocking/allowing one filename should not affect other files.

[jochen (gone - plz use gerrit), 2010-04-21 18:36:40]

On 2010/04/21 18:18:45, jochen wrote:
> On 2010/04/21 18:01:50, Peter Kasting wrote:
> > LGTM
> > 
> > http://codereview.chromium.org/1744003/diff/2001/3002
> > File chrome/browser/renderer_host/async_resource_handler.cc (right):
> > 
> > http://codereview.chromium.org/1744003/diff/2001/3002#newcode123
> > chrome/browser/renderer_host/async_resource_handler.cc:123: host,
> > context->host_zoom_map()->GetZoomLevel(host)));
> > Eventually we want Zoom to do the same thing, but that's probably a large
> change
> > (as I suspect we have to change the zoom map too), so if you're feeling
> > super-generous feel free to add that in, but otherwise this is fine.
> 
> 
> I started implementing this, however, the following issue arised: If you zoom
> e.g. file:///tmp/test.html, can we really assume that you also want to zoom
all
> other file: tabs?
> 
> In contrast, when you zoom google.com/something, then you probably also want
to
> zoom google.com/something/else.
> 
> So I concluded that for zooming, we really want this to be host based.

That's true... so in the end, this would keep all tabs open with
file:///tmp/test.html in sync

Seems easy enough to implement.. will do that

[jochen (gone - plz use gerrit), 2010-04-22 10:00:23]

now with hostzoommap support... please review

[Peter Kasting, 2010-04-22 20:12:41]

LGTM, you rock!

http://codereview.chromium.org/1744003/diff/11001/12013
File net/base/net_util.cc (right):

http://codereview.chromium.org/1744003/diff/11001/12013#newcode1
net/base/net_util.cc:1: // Copyright (c) 2009 The Chromium Authors. All rights
reserved.
Nit: 2010

http://codereview.chromium.org/1744003/diff/11001/12014
File net/base/net_util.h (right):

http://codereview.chromium.org/1744003/diff/11001/12014#newcode1
net/base/net_util.h:1: // Copyright (c) 2009 The Chromium Authors. All rights
reserved.
Nit: 2010

http://codereview.chromium.org/1744003/diff/11001/12014#newcode87
net/base/net_util.h:87: std::string GetHostFromURL(const GURL& url);
Nit: Maybe GetHostOrSpecFromURL() is more accurate?

http://codereview.chromium.org/1744003/diff/11001/12015
File net/base/net_util_unittest.cc (right):

http://codereview.chromium.org/1744003/diff/11001/12015#newcode1
net/base/net_util_unittest.cc:1: // Copyright (c) 2009 The Chromium Authors. All
rights reserved.
Nit: 2010

[jochen (gone - plz use gerrit), 2010-04-23 08:51:38]

http://codereview.chromium.org/1744003/diff/11001/12013
File net/base/net_util.cc (right):

http://codereview.chromium.org/1744003/diff/11001/12013#newcode1
net/base/net_util.cc:1: // Copyright (c) 2009 The Chromium Authors. All rights
reserved.
On 2010/04/22 20:12:42, Peter Kasting wrote:
> Nit: 2010

Done.

http://codereview.chromium.org/1744003/diff/11001/12014
File net/base/net_util.h (right):

http://codereview.chromium.org/1744003/diff/11001/12014#newcode1
net/base/net_util.h:1: // Copyright (c) 2009 The Chromium Authors. All rights
reserved.
On 2010/04/22 20:12:42, Peter Kasting wrote:
> Nit: 2010

Done.

http://codereview.chromium.org/1744003/diff/11001/12014#newcode87
net/base/net_util.h:87: std::string GetHostFromURL(const GURL& url);
On 2010/04/22 20:12:42, Peter Kasting wrote:
> Nit: Maybe GetHostOrSpecFromURL() is more accurate?

Done.

http://codereview.chromium.org/1744003/diff/11001/12015
File net/base/net_util_unittest.cc (right):

http://codereview.chromium.org/1744003/diff/11001/12015#newcode1
net/base/net_util_unittest.cc:1: // Copyright (c) 2009 The Chromium Authors. All
rights reserved.
On 2010/04/22 20:12:42, Peter Kasting wrote:
> Nit: 2010

Done.