Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 174396: Fix another source of flakiness in ErrorPageTest (Closed)

Created:
11 years, 3 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix another source of flakiness in ErrorPageTest We need to wait for correct number of navigations when going back or forward to the LinkDoctor page. Re-enable previously disabled tests and remove the now-duplicate browser test. The test is still not very solid, because the LinkDoctor should be mocked. TEST=Covered by ui_tests. http://crbug.com/19361, http://crbug.com/19395 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24446

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -154 lines) Patch
M chrome/browser/automation/automation_provider.h View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 2 chunks +40 lines, -0 lines 0 comments Download
D chrome/browser/errorpage_browsertest.cc View 1 chunk +0 lines, -132 lines 0 comments Download
M chrome/browser/errorpage_uitest.cc View 5 chunks +9 lines, -13 lines 1 comment Download
M chrome/chrome.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/automation/automation_messages_internal.h View 3 chunks +34 lines, -6 lines 0 comments Download
M chrome/test/automation/tab_proxy.h View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/test/automation/tab_proxy.cc View 1 chunk +15 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paweł Hajdan Jr.
11 years, 3 months ago (2009-08-25 15:26:16 UTC) #1
huanr
11 years, 3 months ago (2009-08-25 20:54:37 UTC) #2
LGTM

http://codereview.chromium.org/174396/diff/1/5
File chrome/browser/errorpage_uitest.cc (right):

http://codereview.chromium.org/174396/diff/1/5#newcode65
Line 65: GetActiveTab()->GoBackBlockUntilNavigationsComplete(2);
please add a comment to explain the number of navigation being 2.

Powered by Google App Engine
This is Rietveld 408576698