Issue 174394: X64: Small changes to let WIN64 platform compile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 174394: X64: Small changes to let WIN64 platform compile. (Closed)

Created:
11 years, 4 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

X64: Small changes to let WIN64 platform compile. Committed: http://code.google.com/p/v8/source/detail?r=2755

Patch Set 1 #

Total comments: 2

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -30 lines)			Patch
M	src/x64/builtins-x64.cc	View	4 chunks	+3 lines, -4 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	5 chunks	+15 lines, -12 lines	0 comments	Download
M	src/x64/frames-x64.h	View	1 chunk	+2 lines, -0 lines	2 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	src/x64/regexp-macro-assembler-x64.cc	View	11 chunks	+12 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/174394/diff/1/3 File src/x64/frames-x64.h (right): http://codereview.chromium.org/174394/diff/1/3#newcode64 Line 64: static const int kArgvOffset = 5 * ...

11 years, 4 months ago (2009-08-25 12:22:28 UTC) #2

William Hesse

11 years, 4 months ago (2009-08-26 06:58:39 UTC) #3

http://codereview.chromium.org/174394/diff/1/3
File src/x64/frames-x64.h (right):

http://codereview.chromium.org/174394/diff/1/3#newcode64
Line 64: static const int kArgvOffset          = 5 * kPointerSize;
On 2009/08/25 12:22:28, Lasse Reichstein wrote:
> Where is it used?


builtins-x64.cc:782

Expand Messages | Collapse Messages