Issue 174380: Try one more time to lock down content sniffing for

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 174380: Try one more time to lock down content sniffing for (Closed)

Created:
11 years, 4 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Try one more time to lock down content sniffing for Chrome extensions. Last time I tried to check this in, I had to roll it back because it made installing extensions from file:// URLs not work. Turned out that we just have to add a single line mapping the ".crx" extension to our mimetype. BUG=13296 TEST=Install an extension from the interweb, it should install. Install an extension from disk, it should install. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24216

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -18 lines)			Patch
	M	chrome/browser/download/download_manager.cc	View		4 chunks	+3 lines, -17 lines	0 comments	Download
	M	net/base/mime_util.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages