Issue 174378: Step 1 in porting page cycler http to linux. Add http startup to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 174378: Step 1 in porting page cycler http to linux. Add http startup to (Closed)

Created:
11 years, 4 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Nirnimesh

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Step 1 in porting page cycler http to linux. Add http startup to the the platform utils. BUG=15470

Patch Set 4 : sleep #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+278 lines, -2 lines)			Patch
A	tools/python/google/httpd_config/httpd2_linux.conf	View		1 chunk	+139 lines, -0 lines	0 comments	Download
M	tools/python/google/platform_utils.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A	tools/python/google/platform_utils_linux.py	View	1 2 3	1 chunk	+137 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tony

platform_utils_linux.py is almost a direct copy of the mac version. httpd2_linux.conf is a stripped down ...

11 years, 4 months ago (2009-08-25 00:50:52 UTC) #1

Nirnimesh

LGTM http://codereview.chromium.org/174378/diff/1/4 File tools/python/google/platform_utils_linux.py (right): http://codereview.chromium.org/174378/diff/1/4#newcode112 Line 112: ' -c \'LockFile "%(lock_file)s"\'' Don't you need ...

11 years, 4 months ago (2009-08-25 11:17:12 UTC) #2

tony

11 years, 4 months ago (2009-08-25 17:45:47 UTC) #3

On 2009/08/25 11:17:12, Nirnimesh wrote:
> LGTM
> 
> http://codereview.chromium.org/174378/diff/1/4
> File tools/python/google/platform_utils_linux.py (right):
> 
> http://codereview.chromium.org/174378/diff/1/4#newcode112
> Line 112: ' -c \'LockFile "%(lock_file)s"\''
> Don't you need -c SSLCertificateFile to use https?

Fixed.  I had to enable mod_ssl for it to work.  I also added a sleep to the
stop http server command because sometimes the port wasn't available fast enough
for the second http page cycler.

Expand Messages | Collapse Messages

Issue 174378: Step 1 in porting page cycler http to linux. Add http startup to (Closed)

Description

Patch Set 1 #

Patch Set 2 : ssl #

Patch Set 3 : stop #

Patch Set 4 : sleep #

Messages