Linux: fix a couple problems that Lintian reports for the .deb file:...

Linux: fix a couple problems that Lintian reports for the .deb file:
  - Eliminate useless call to ldconfig (see Debian bug #364436)
  - Eliminate spurious rpath. We were setting the rpath equal to the build output directory for libs, which is wrong. The rpath is the _run-time_ library search path for the resulting binary, i.e. the one used by ld.so at load time. Setting it equal to the path to build output on the build machine is nonsense.
Also:
  - Use new-found knowledge of rpath to eliminate the need to symlink into /usr/lib(32) by instead setting rpath to /opt/google/o3d/lib and putting our three dependent libs there.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24250

[piman, 2009-08-25 01:17:36]

LGTM

http://codereview.chromium.org/174369/diff/1/2
File plugin/build.scons (right):

http://codereview.chromium.org/174369/diff/1/2#newcode248
Line 248: env.Append(RPATH=['/opt/google/o3d/lib'])
Could you add a comment describing what this does ? I just read on it, good
find.

I'm not 100% comfortable hard-coding that path at build time (I can see this
biting us later for local development if say we want to update versions of these
libs), but I guess it can't be worse than what was there already.

[noah, 2009-08-25 15:25:50]

LGTM

[Tristan Schmelcher, 2009-08-25 17:12:16]

Yay, I can update issues again!

http://codereview.chromium.org/174369/diff/1/2
File plugin/build.scons (right):

http://codereview.chromium.org/174369/diff/1/2#newcode248
Line 248: env.Append(RPATH=['/opt/google/o3d/lib'])
On 2009/08/25 01:17:36, piman wrote:
> Could you add a comment describing what this does ? I just read on it, good
> find.
> 
> I'm not 100% comfortable hard-coding that path at build time (I can see this
> biting us later for local development if say we want to update versions of
these
> libs), but I guess it can't be worse than what was there already.

Done.

I briefly considered making this overridable with a command-line option, but
it's dirt simple to just run "sudo dpkg -i" on the built .deb file to test it,
so there's no need really.