Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 17436: Generation of net .vcproj and .sln files.... (Closed)

Created:
11 years, 11 months ago by sgk
Modified:
9 years, 5 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Generation of net .vcproj and .sln files. Specific changes: * Add to MSVSProject() calls: GUID, input_files list, tools list (that are common to the individual configurations). * Add *.h files and MSVSFilter() hierarchies to input_files lists. * Switch to using the .Remove() method for instead of by-hand Python to remove things from input_files lists. * Use of precompiled header files still requires separate by-hand Configuration specifications. * Remove .dat files from the input file lists when compiling. * Extensive _Node_MSVS.py changes that set us up for deducing this information from parallel Debug and Release builds instead of configuring things by hand, basically by delaying evaluation of most of the strings, then introspecting on the command lines that will be used to generate the targets and translating compiler and linker options into Visual Studio settings. The result is (again) byte-for-byte identical .vcproj files, modulo removal of a ".\" current-directory prefix for a few RelativePath specifications. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7826

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 4

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1115 lines, -202 lines) Patch
M net/crash_cache.scons View 1 2 3 1 chunk +56 lines, -10 lines 0 comments Download
M net/dump_cache.scons View 1 2 3 1 chunk +54 lines, -9 lines 0 comments Download
M net/net_lib.scons View 1 2 3 7 chunks +307 lines, -50 lines 0 comments Download
M net/net_perftests.scons View 1 2 3 1 chunk +73 lines, -15 lines 0 comments Download
M net/net_unittests.scons View 1 2 3 3 chunks +160 lines, -48 lines 0 comments Download
M net/stress_cache.scons View 1 2 3 1 chunk +55 lines, -10 lines 0 comments Download
M net/tools/tld_cleanup/tld_cleanup.scons View 1 2 3 1 chunk +54 lines, -9 lines 0 comments Download
M site_scons/site_tools/_Node_MSVS.py View 1 2 3 20 chunks +352 lines, -49 lines 0 comments Download
M site_scons/site_tools/chromium_builders.py View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sgk
11 years, 11 months ago (2009-01-09 00:12:29 UTC) #1
darin (slow to review)
I didn't review anything under site_tools http://codereview.chromium.org/17436/diff/20/203 File net/net_lib.scons (right): http://codereview.chromium.org/17436/diff/20/203#newcode252 Line 252: MSVSFilter('ftp', [ ...
11 years, 11 months ago (2009-01-09 00:39:56 UTC) #2
sgk
11 years, 11 months ago (2009-01-09 01:05:33 UTC) #3
http://codereview.chromium.org/17436/diff/20/203
File net/net_lib.scons (right):

http://codereview.chromium.org/17436/diff/20/203#newcode252
Line 252: MSVSFilter('ftp', [
On 2009/01/09 00:39:56, darin wrote:
> do we really need MSVSFilter?  wouldn't it be possible to just derive this
from
> the directory path instead?

Yes, we'll do that eventually.  This is an incremental step to that.  I'm doing
it this manually so the generated .vcproj exactly matches our current checked-in
.vcproj (or as nearly as practical) so we're not changing multiple things at
once (generation *and* project layout).

http://codereview.chromium.org/17436/diff/20/204
File net/net_perftests.scons (right):

http://codereview.chromium.org/17436/diff/20/204#newcode78
Line 78: tools=[
On 2009/01/09 00:39:56, darin wrote:
> it seems a shame to have to list tools here that are in the default set. 
maybe
> we could get by only listing tools that have custom properties or that are not
> in the default set?

I should be able to check in a follow-on that pulls this from a common setting
in the environment.  Sound good?

Also:  a lot of these can go away completely, but again, the idea here is to
check in generation that exactly matches what we have now and then clean things
up incrementally.

Powered by Google App Engine
This is Rietveld 408576698